Skip to content

Fix .sln project generation logic for Rider to support all OS and all C++ toolchains #103405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Fix .sln project generation logic for Rider to support all OS and all C++ toolchains #103405

merged 1 commit into from
Apr 9, 2025

Conversation

van800
Copy link
Contributor

@van800 van800 commented Feb 28, 2025 •
edited
Loading

fixes #83771

related doc update godotengine/godot-docs#10754

I have checked Mac, Linux and Windows with MinGV, Windows with MSVC

@van800 van800 requested a review from a team as a code owner February 28, 2025 16:30
@van800 van800 mentioned this pull request Feb 28, 2025
Closed
@AThousandShips AThousandShips added this to the 4.x milestone Feb 28, 2025
@van800 van800 mentioned this pull request Mar 1, 2025
Closed
@van800 van800 changed the title [WIP] Developing in Rider w/o MSVC toolchain Fix project generation logic for Rider to support any OS without MSVC toolchain Mar 1, 2025
@van800 van800 changed the title Fix project generation logic for Rider to support any OS without MSVC toolchain Fix project generation logic for Rider to support all OS (without MSVC toolchain) Mar 1, 2025
@van800
Copy link
Contributor Author

van800 commented Mar 3, 2025

@shana would you mind taking a look at this PR, when you have time? Thank you!
Sorry for the ping, I thought you might be interested, since you did the previous massive refactoring of the generation logic.

shana
shana suggested changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@shana shana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for Rider support! However, there are a number of things on this PR that will break a bunch of things (including all of the console platforms), so I've left comments, hopefully this can be made to work for everyone without breaking things.

@van800 van800 force-pushed the shakhov/macosx branch 8 times, most recently from 8878108 to 128509b Compare March 4, 2025 07:24
@van800 van800 requested a review from shana March 4, 2025 11:36
shana
shana reviewed Mar 4, 2025
View reviewed changes
shana
shana reviewed Mar 4, 2025
View reviewed changes
shana
shana reviewed Mar 4, 2025
View reviewed changes
shana
shana reviewed Mar 4, 2025
View reviewed changes
shana
shana reviewed Mar 4, 2025
View reviewed changes
@van800 van800 requested a review from shana March 5, 2025 18:53
@van800 van800 force-pushed the shakhov/macosx branch 2 times, most recently from 7c72b2e to cfc0f18 Compare March 8, 2025 05:35
@van800 van800 force-pushed the shakhov/macosx branch 2 times, most recently from 4c689dc to 3681362 Compare March 13, 2025 20:16
@van800 van800 changed the title Fix project generation logic for Rider to support all OS (without MSVC toolchain) Fix project generation logic for Rider to support all OS and all toolchains Mar 13, 2025
@van800 van800 changed the title Fix project generation logic for Rider to support all OS and all toolchains Fix project generation logic for Rider to support all OS and all Cpp toolchains Mar 13, 2025
@van800 van800 force-pushed the shakhov/macosx branch 5 times, most recently from f27f3e3 to 2c723f2 Compare March 13, 2025 21:38
@van800 van800 requested a review from shana March 13, 2025 21:40
@van800 van800 force-pushed the shakhov/macosx branch 2 times, most recently from e3369b0 to b62a3db Compare March 26, 2025 01:15
@van800 van800 requested a review from a team as a code owner April 4, 2025 12:55
@van800 van800 force-pushed the shakhov/macosx branch 2 times, most recently from 44e8861 to 6057bbf Compare April 7, 2025 17:35
shana
shana approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@shana shana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and it's working well with all of my testing 👍

@van800 van800 force-pushed the shakhov/macosx branch 2 times, most recently from 347af2d to 669170b Compare April 8, 2025 13:29
@akien-mga akien-mga changed the title Fix project generation logic for Rider to support all OS and all Cpp toolchains Fix .sln project generation logic for Rider to support all OS and all C++ toolchains Apr 8, 2025
@akien-mga akien-mga modified the milestones: 4.x, 4.5 Apr 8, 2025
@van800
Copy link
Contributor Author

van800 commented Apr 8, 2025

Updated the commit message to match the pull request title.

akien-mga
akien-mga approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable to me. I haven't reviewed in-depth nor tested, but trust shana's review on this code.

@van800 @shana @akien-mga
Fix .sln project generation logic for Rider to support all OS and all…
6ff86e4 
… C++ toolchains

Co-authored-by: Andreia Gaita <[email protected]>
Co-authored-by: Rémi Verschelde <[email protected]>
@Repiteo Repiteo merged commit 4362b11 into godotengine:master Apr 9, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Apr 9, 2025

Thanks!

@akien-mga akien-mga mentioned this pull request May 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shana shana shana approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos topic:buildsystem
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

Cannot generate godot.sln for Rider under MacOS
5 participants
@van800 @shana @Repiteo @akien-mga @AThousandShips