Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake options to enable or disable installation of mujoco samples and simulate #1477

Closed
wants to merge 1 commit into from

Conversation

traversaro
Copy link
Contributor

The current logic uses regular CMake variables, that create confusing behavior when a CMake cache variable with the same name is set from the command line. The PR does not change the behaviour of the build system, but permits to users to enable installation of simulate and samples executables from the CMake options.

@traversaro traversaro changed the title Add options to enable or disable installation of mujoco samples and simulate Add CMake options to enable or disable installation of mujoco samples and simulate Mar 5, 2024
@traversaro
Copy link
Contributor Author

@traversaro traversaro closed this Mar 5, 2024
@traversaro
Copy link
Contributor Author

Unfortunatly, this can't work if we do not also duplicate the TargetAddRpath.cmake module in https://github.com/google-deepmind/mujoco/tree/7e87c6ac44ef980dbc5bb16f45100cd8b63c427b/sample/cmake and https://github.com/google-deepmind/mujoco/tree/7e87c6ac44ef980dbc5bb16f45100cd8b63c427b/simulate/cmake .

Actually, we can make it work without duplication when MUJOCO_ENABLE_RPATH is OFF.

@traversaro
Copy link
Contributor Author

Unfortunatly, this can't work if we do not also duplicate the TargetAddRpath.cmake module in https://github.com/google-deepmind/mujoco/tree/7e87c6ac44ef980dbc5bb16f45100cd8b63c427b/sample/cmake and https://github.com/google-deepmind/mujoco/tree/7e87c6ac44ef980dbc5bb16f45100cd8b63c427b/simulate/cmake .

Actually, we can make it work without duplication when MUJOCO_ENABLE_RPATH is OFF.

Fixed this in #1478, not sure why I can't reopen this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant