Skip to content

Conversation

@jkroepke
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #19655

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jkroepke jkroepke requested a review from a team as a code owner November 14, 2025 15:40
@jkroepke jkroepke changed the title feat(helm): do not mark loki.storage.bucketNames.chunks as required, if minio is used. fix(helm): do not mark loki.storage.bucketNames.chunks as required, if minio is used. Nov 14, 2025
@jkroepke
Copy link
Contributor Author

@QuentinBisson 🥺

Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayclifford345 Jayclifford345 merged commit eddd4f8 into grafana:main Nov 20, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

helm-loki-6.45.1: requires loki.storage.bucketNames.chunks even for filesystem

3 participants