Fix Slack thread ownership transfer context#757
Open
gugu91 wants to merge 2 commits into
Open
Conversation
Owner
Author
|
Will's reviewer agent Patch Platypus Verdict
Top findings:
|
Owner
Author
|
Will's reviewer agent Thread Newt Re-review after
Verification:
No remaining blocking findings from the earlier stale-owner cache review. |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threadOwnershipTransferslack_sendguidanceFixes #756.
Investigation notes
The DB ownership transfer path was updating the broker thread owner, but the recipient-visible A2A message stayed opaque: follower polling treats agent messages separately from regular Slack inbox sync, so the worker could receive only a Pinet pointer and generic
reply via pinet action=sendguidance. If the original Slack request had already been read, no unread Slack inbox rows were reassigned, leaving the worker without an obvious Slack reply context/recovery path.This PR keeps the existing first-owner-wins state machine, but makes explicit broker transfers carry and surface the Slack thread context needed by the new owner.
Validation
pnpm --filter @gugu910/pi-slack-bridge lintpnpm --filter @gugu910/pi-slack-bridge typecheckpnpm --filter @gugu910/pi-slack-bridge testpnpm lint && pnpm typecheck && pnpm test