-
Notifications
You must be signed in to change notification settings - Fork 33
Yet another attempt to update to latest v2 #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
src/DesignState.cs
Outdated
@@ -21,18 +24,17 @@ public class DesignState | |||
public DesignState(Design design) | |||
{ | |||
this.Design = design; | |||
this.OriginalScheme = this.Design.View.GetExplicitColorScheme(); | |||
this.Design.View.DrawComplete += this.DrawContentComplete; | |||
this.Design.View.DrawComplete += this.DrawContentComplete; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format in this line.
src/UI/Editor.cs
Outdated
}; | ||
rootCommandsListView.SetScheme(new Scheme | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
this.btnAddElement.CanFocus = true; | ||
this.btnAddElement.ShadowStyle = Terminal.Gui.ShadowStyle.Opaque; | ||
this.btnAddElement.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed; | ||
this.btnAddElement.CanFocus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
this.btnDelete.CanFocus = true; | ||
this.btnDelete.ShadowStyle = Terminal.Gui.ShadowStyle.Opaque; | ||
this.btnDelete.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed; | ||
this.btnDelete.CanFocus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
this.btnMoveUp.CanFocus = true; | ||
this.btnMoveUp.ShadowStyle = Terminal.Gui.ShadowStyle.Opaque; | ||
this.btnMoveUp.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed; | ||
this.btnMoveUp.CanFocus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
src/UI/Windows/PosEditor.Designer.cs
Outdated
this.btnOk.CanFocus = true; | ||
this.btnOk.ShadowStyle = Terminal.Gui.ShadowStyle.Opaque; | ||
this.btnOk.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed; | ||
this.btnOk.CanFocus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
src/UI/Windows/PosEditor.Designer.cs
Outdated
this.btnCancel.CanFocus = true; | ||
this.btnCancel.ShadowStyle = Terminal.Gui.ShadowStyle.Opaque; | ||
this.btnCancel.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed; | ||
this.btnCancel.CanFocus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
this.btnOk.CanFocus = true; | ||
this.btnOk.ShadowStyle = Terminal.Gui.ShadowStyle.Opaque; | ||
this.btnOk.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed; | ||
this.btnOk.CanFocus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
this.btnCancel.CanFocus = true; | ||
this.btnCancel.ShadowStyle = Terminal.Gui.ShadowStyle.Opaque; | ||
this.btnCancel.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed; | ||
this.btnCancel.CanFocus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
this.btnCancel.CanFocus = true; | ||
this.btnCancel.ShadowStyle = Terminal.Gui.ShadowStyle.Opaque; | ||
this.btnCancel.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed; | ||
this.btnCancel.CanFocus = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format here.
Hmn good point, I should open and save all these dialogs that will either fix the problem or show that the problem is in code gen. |
If it's due code gen it's preferable fix the indention in the code gen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This was huge.
Changes:
Manual Testing:
I have tested this by deleting and recreating showcases
Outstanding Issues (will not fix)