Draft
Conversation
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
will-moore
force-pushed
the
z_downsampling
branch
from
2c6887f to
19d87d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Z-downsampling issue reported at BioNGFF#16
We add an
originalSizeZattribute to everyZarrPixelSourcein the pyramid so that each array knows if it is smaller than the original. Then, we can use that ratio to adjust the chosenzindex when we choose the indecies to load from the zarr array.To test (images which are downsampled in Z):
Screenshot of the bigger image above showing a mixture of high-resolution tiles loaded amongst lower resolution tiles - both coming from different Z sections but are compatible with each other: