Fix: Resolve Incorrect Configuration and Implement CRUD Features for NewsletterRepository#688
Merged
Am0du merged 10 commits intohngprojects:devfrom Mar 2, 2025
Merged
Conversation
Am0du
requested changes
Feb 28, 2025
Contributor
Am0du
left a comment
There was a problem hiding this comment.
Based on your issue, you need to create User and Newsletter relationship with One-to-Many (creator) and Many-to-Many (subscriptions) relationships.
Implement service methods to subscribe(subscription is already in the codebase)/unsubscribe users and repository methods for database operations.
Also no endpoints for implemented service
src/main/java/hng_java_boilerplate/newsletter/repository/NewsletterRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/repository/NewsletterRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/repository/NewsletterRepository.java
Outdated
Show resolved
Hide resolved
…tory Interface endpoints
Am0du
requested changes
Feb 28, 2025
src/main/java/hng_java_boilerplate/newsletter/service/NewsletterService.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/service/NewsletterService.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/repository/NewsletterRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/entity/Subscriber.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/dto/DeleteRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/controller/NewsletterController.java
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/controller/NewsletterController.java
Outdated
Show resolved
Hide resolved
…tory Interface endpoints with pagination
Am0du
requested changes
Mar 1, 2025
src/main/java/hng_java_boilerplate/newsletter/controller/NewsletterController.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/controller/NewsletterController.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/controller/NewsletterController.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/controller/NewsletterController.java
Outdated
Show resolved
Hide resolved
src/main/java/hng_java_boilerplate/newsletter/controller/NewsletterController.java
Outdated
Show resolved
Hide resolved
…tory Interface endpoints with pagination hngprojects#2
Contributor
|
@Am0du can you please reviews this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR resolves the incorrect configuration of the
NewsletterRepository interfaceand implements CRUD features, including retrieving newsletters by user ID, retrieving newsletters created after a specified date, and deleting newsletters by user ID.Bug fixes:
*Resolved incorrect configuration of
NewsletterRepositoryinterface##New features:
@Entity newsletterExpected Behavior
The
NewsletterRepositoryshould correctly perform CRUD operations using the defined@Queryannotations.getNewslettersByUserIdEndpointgetNewslettersAfterDateEndpointTesting
Test 1: Retrieve newsletters by user ID
Test 2: Retrieve newsletters created after a specified date
Test 3: Delete newsletter by user ID