-
Notifications
You must be signed in to change notification settings - Fork 54
Fix: Resolve Incorrect Configuration and Implement CRUD Features for NewsletterRepository #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4b238f3
Fix(JPA): Invalid repository configuration in newsletterRepository In…
tachtwitch 1cf1e0e
Fix: Incorrect newsletter entity relations and added newsletterReposi…
tachtwitch 7152dc8
Fix: Incorrect newsletter entity relations and added newsletterReposi…
tachtwitch 9335765
Fix: Incorrect newsletter entity relations and added newsletterReposi…
tachtwitch 18b59b6
Merge branch 'dev' into add-tachtwitch
tachtwitch 28acf1a
Merge branch 'dev' into add-tachtwitch
tachtwitch 9ee04fc
Merge branch 'dev' into add-tachtwitch
Am0du 739c0f1
Update User.java
tachtwitch 1cd7e1c
FIX[BUG]: Fix redudant endpoint bug in newsletterController
tachtwitch c7ddafa
Merge branch 'dev' into add-tachtwitch
Am0du File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| Tachtwitch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/main/java/hng_java_boilerplate/newsletter/dto/DeleteRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package hng_java_boilerplate.newsletter.dto; | ||
|
|
||
| import lombok.Getter; | ||
| import lombok.Setter; | ||
|
|
||
| @Getter | ||
| @Setter | ||
| public class DeleteRequest { | ||
| private String user_id; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 15 additions & 1 deletion
16
src/main/java/hng_java_boilerplate/newsletter/repository/NewsletterRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,21 @@ | ||
| package hng_java_boilerplate.newsletter.repository; | ||
|
|
||
|
|
||
| import hng_java_boilerplate.newsletter.entity.Newsletter; | ||
| import org.springframework.data.domain.Page; | ||
| import org.springframework.data.domain.Pageable; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
| import org.springframework.data.jpa.repository.Query; | ||
| import org.springframework.data.repository.query.Param; | ||
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| public interface NewsletterRepository extends JpaRepository<Newsletter, String> { | ||
| } | ||
|
|
||
| Page<Newsletter> findByUser_Id(String userId, Pageable page); | ||
|
|
||
| @Query("SELECT n FROM Newsletter n WHERE n.createdAt > :date") | ||
| <Optional> Page<Newsletter> findNewsletterByCreatedAtAfter(@Param("date") LocalDateTime date, Pageable page); | ||
|
|
||
| void deleteByUser_Id(String userId); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
src/main/resources/db/migration/V49__alter_newsletter_product_table.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ALTER TABLE newsletters | ||
| ADD COLUMN title VARCHAR(255), | ||
| ADD COLUMN content TEXT |
2 changes: 2 additions & 0 deletions
2
src/main/resources/db/migration/V50__alter_newsletter_table.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ALTER TABLE newsletters | ||
| DROP COLUMN user_id |
15 changes: 15 additions & 0 deletions
15
src/main/resources/db/migration/V51__create_subscription_table.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ALTER TABLE newsletters | ||
| ADD COLUMN user_id VARCHAR(50), | ||
| ADD CONSTRAINT fk_user_id | ||
| FOREIGN KEY (user_id) | ||
| REFERENCES users(id) | ||
| ON DELETE CASCADE | ||
| ON UPDATE CASCADE; | ||
|
|
||
| CREATE TABLE subscribers( | ||
| user_id VARCHAR(50), | ||
| newsletter_id VARCHAR(50), | ||
| PRIMARY KEY (user_id, newsletter_id), | ||
| FOREIGN KEY (user_id) REFERENCES users(id), | ||
| FOREIGN KEY (newsletter_id) REFERENCES newsletters(id), | ||
| subscribed_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP); |
100 changes: 100 additions & 0 deletions
100
src/test/java/hng_java_boilerplate/newsletter/unit_test/NewsletterTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| package hng_java_boilerplate.newsletter.unit_test; | ||
|
|
||
| import hng_java_boilerplate.newsletter.entity.Newsletter; | ||
| import hng_java_boilerplate.newsletter.repository.NewsletterRepository; | ||
| import hng_java_boilerplate.newsletter.service.NewsletterService; | ||
| import hng_java_boilerplate.user.dto.response.Response; | ||
| import hng_java_boilerplate.user.entity.User; | ||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.InjectMocks; | ||
| import org.mockito.Mock; | ||
| import org.mockito.MockitoAnnotations; | ||
| import org.springframework.data.domain.Page; | ||
| import org.springframework.data.domain.PageImpl; | ||
| import org.springframework.data.domain.PageRequest; | ||
| import org.springframework.data.domain.Pageable; | ||
|
|
||
| import java.time.LocalDateTime; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.mockito.Mockito.*; | ||
|
|
||
| public class NewsletterTest { | ||
|
|
||
| @InjectMocks | ||
| private NewsletterService newsletterService; | ||
| @Mock | ||
| private NewsletterRepository newsletterRepository; | ||
|
|
||
| private Newsletter newsletter1; | ||
| private Newsletter newsletter2; | ||
|
|
||
| @BeforeEach | ||
| void setup() { | ||
| MockitoAnnotations.openMocks(this); | ||
| User user = new User(); | ||
| user.setId("U1"); | ||
| user.setName("John Doe"); | ||
| user.setEmail("johndoe@example.com"); | ||
| user.setCreatedAt(LocalDateTime.now()); | ||
|
|
||
| newsletter1 = new Newsletter(); | ||
| newsletter1.setUser(user); | ||
| newsletter1.setCreatedAt(LocalDateTime.now()); | ||
| newsletter1.setId("1"); | ||
| newsletter1.setTitle("Newsletter test"); | ||
| newsletter1.setUpdatedAt(LocalDateTime.now()); | ||
| newsletter1.setContent("this a test content for the newsletter"); | ||
|
|
||
| newsletter2 = new Newsletter(); | ||
| newsletter1.setUser(user); | ||
| newsletter2.setCreatedAt(LocalDateTime.now()); | ||
| newsletter2.setId("2"); | ||
| newsletter2.setUpdatedAt(LocalDateTime.now()); | ||
| newsletter2.setTitle("Newsletter test2"); | ||
| newsletter2.setContent("this a second test content for the newsletter"); | ||
| } | ||
|
|
||
| @Test | ||
| void testFindByUserId(){ | ||
| List<Newsletter> newsletters = Arrays.asList(newsletter1,newsletter2); | ||
| Page<Newsletter> page = new PageImpl<>(newsletters); | ||
| Pageable pageable = PageRequest.of(0,1); | ||
|
|
||
| when(newsletterRepository.findByUser_Id("U1",pageable)).thenReturn(page); | ||
|
|
||
| Page<Newsletter> result = newsletterService.findNewsletterByUserId(newsletter1.getUser().getId(),pageable); | ||
|
|
||
| assertNotNull(result); | ||
| assertEquals(1,result.getTotalPages()); | ||
| verify(newsletterRepository, times(1)).findByUser_Id(newsletter1.getUser().getId(),pageable); | ||
| } | ||
|
|
||
| @Test | ||
| void testFindByCreatedAfter(){ | ||
| List<Newsletter> newsletters = Arrays.asList(newsletter1,newsletter2); | ||
| Page<Newsletter> page = new PageImpl<>(newsletters,PageRequest.of(0,1),2); | ||
| LocalDateTime date = LocalDateTime.parse("2025-02-28T11:44:32.180026100"); | ||
| when(newsletterRepository.findNewsletterByCreatedAtAfter(date,page.getPageable())).thenReturn(page); | ||
|
|
||
| Page<Newsletter> result = newsletterService.findNewsletterByCreatedAtAfter(date,page.getPageable()); | ||
|
|
||
| assertNotNull(result); | ||
| verify(newsletterRepository, times(1)).findNewsletterByCreatedAtAfter(date,page.getPageable()); | ||
| } | ||
|
|
||
| @Test | ||
| void testDeleteByUserId(){ | ||
| String userId = newsletter1.getUser().getId(); | ||
|
|
||
| Response<?> response = newsletterService.deleteNewsletterByUserId(userId); | ||
|
|
||
| assertEquals("success", response.getStatus_code()); | ||
| assertEquals("Newsletter deleted successfully.", response.getMessage()); | ||
| verify(newsletterRepository, times(1)).deleteByUser_Id(userId); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.