BaseException should not be caught #29
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the exception heirarchy, there are 3 Exceptions derived from
Exceptionand notBaseException.KeyboardInterruptSystemExitGeneratorExitKeyboardInterruptandSystemExitare typically not caught, as Python is closing anyways. I believe catching them interferes with e.g. CTRL+C.GeneratorExitdoes not seem relevant here. Even if it were, it must be re-raised orRuntimeError: generator ignored GeneratorExitwill occur.I therefore propose changing all usages of
except BaseExceptiontoexcept Exception.This resolves a single error with
pyrightormypy. However, it does technically represent a change frompyserial.