feat: prefer reading the build toml from current ref#982
Conversation
drbh
added
area: github-actions
|
Cc: @drbh possible to revive this one? |
|
|
||
|
|
||
| # Metadata read from a git ref (PR branch) instead of the working tree. | ||
| class MetadataRefTest(unittest.TestCase): |
There was a problem hiding this comment.
I think there should also be a test to ensure that the dispatcher is able to select the right workflows? For example, #1031 shouldn't have picked the building on Mac workflow?
There was a problem hiding this comment.
yea good point - test_metadata_ref_routes_metal_less_kernel_without_mac_build should cover this case, it reads a cuda only kernel from the ref and asserts it only routes to build.yaml (no build-mac.yaml)
thats what happened in #1031, build.toml didn't exist on the base ref yet so read_backends returned None and we fell back to dispatching every build, mac included. reading the toml from the PR ref is the fix
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks! Let's ship it and fix any bugs that might surface later.
2 participants
this PR updates the kernel bot to prefer reading the build toml from the PR ref its on
pending the refactor PR #983
should address #935