Skip to content

fix: handle clone timeout gracefully in github_client #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hummbl-dev merged 2 commits into from
Apr 19, 2026
Merged

fix: handle clone timeout gracefully in github_client #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0826772
fix: handle clone timeout gracefully in github_client
Apr 19, 2026
09b9266
fix(preflight): detect dependency-error comment patterns on imports
Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/arbiter/github_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,14 @@ def clone_repos(
cmd.extend(["--", repo.clone_url, str(dest)])

print(f" Cloning {repo.full_name} ({repo.stars:,} stars)...", file=sys.stderr)
result = subprocess.run(cmd, capture_output=True, text=True, timeout=300)
if result.returncode == 0:
cloned.append(dest)
else:
print(f" SKIP {repo.full_name}: {result.stderr.strip()[:100]}", file=sys.stderr)
try:
result = subprocess.run(cmd, capture_output=True, text=True, timeout=300)
if result.returncode == 0:
cloned.append(dest)
else:
print(f" SKIP {repo.full_name}: {result.stderr.strip()[:100]}", file=sys.stderr)
except subprocess.TimeoutExpired:
print(f" SKIP {repo.full_name}: clone timed out (300s)", file=sys.stderr)

return cloned

Expand Down
2 changes: 1 addition & 1 deletion src/arbiter/preflight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def check_comment_reexports(repo_path: Path, changed_files: list[str]) -> list[s
the import is intentional even though the symbol isn't used in this file.
"""
_REEXPORT_PATTERNS = re.compile(
r"#.*\b(expose|re-?export|public api|make available|forward)\b",
r"#.*\b(expose|re-?export|public api|make available|forward|dependency|missing dep|error message|ensure|verify|check.*install)\b",
re.IGNORECASE,
)
warnings = []
Expand Down
Loading