Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poi_df function cleaned up a bit #74

Merged
merged 2 commits into from
Mar 17, 2025
Merged

poi_df function cleaned up a bit #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4d154e
little for loop cleanup in the poi_df function.
ahaj Mar 17, 2025
7d60dc0
whoops! forgot t'change path in 0.
ahaj Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions 0_Workspace_setup.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,26 +119,6 @@
"jupyter_black.load()"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "5353538e-4099-4a1c-937e-ee781ef57d37",
"metadata": {},
"outputs": [],
"source": [
"#!pip install nbqa"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "740df1cc-43f0-4ec7-8ff5-6ad13a2583cd",
"metadata": {},
"outputs": [],
"source": [
"#!nbqa ruff 6_Streamflow_Output_Visualization.ipynb"
]
},
{
"cell_type": "markdown",
"id": "851d845f-9086-4d43-8864-ffd1a2b4a398",
Expand Down
36 changes: 0 additions & 36 deletions 2_Model_Hydrofabric_Visualization.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,42 +44,6 @@
")"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "57359be0-4ddf-42b4-9168-48b50695486c",
"metadata": {},
"outputs": [],
"source": [
"# poi_df = create_poi_df(\n",
"# model_dir,\n",
"# param_filename,\n",
"# control_file_name,\n",
"# hru_gdf,\n",
"# gages_file,\n",
"# default_gages_file,\n",
"# nwis_gage_nobs_min,\n",
"# )"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "7860ced9-da52-4314-a7d0-a852501df4c4",
"metadata": {},
"outputs": [],
"source": [
"print(gages_file)"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "981b533f-c1b0-436c-8d09-3ae4c643b20e",
"metadata": {},
"outputs": [],
"source": []
},
{
"cell_type": "markdown",
"id": "4db74d32",
Expand Down
61 changes: 20 additions & 41 deletions NHM_helpers/NHM_hydrofabric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,27 +286,16 @@ def create_poi_df(
)

for idx, row in poi_df.iterrows():
if pd.isnull(row["latitude"]):
new_poi_id = row["poi_id"]
new_lat = gages_df.loc[
gages_df.index == row["poi_id"], "latitude"
].values[0]
new_lon = gages_df.loc[
gages_df.index == row["poi_id"], "longitude"
].values[0]
new_poi_agency = gages_df.loc[
gages_df.index == row["poi_id"], "poi_agency"
].values[0]
new_poi_name = gages_df.loc[
gages_df.index == row["poi_id"], "poi_name"
].values[0]

poi_df.loc[idx, "latitude"] = new_lat
poi_df.loc[idx, "longitude"] = new_lon
poi_df.loc[idx, "poi_id"] = new_poi_id
poi_df.loc[idx, "poi_agency"] = new_poi_agency
poi_df.loc[idx, "poi_name"] = new_poi_name

"""
Checks the gages_df for missing meta data and replace.
"""
columns = ["latitude", "longitude", "poi_name", "poi_agency"]
for item in columns:
if pd.isnull(row[item]):
new_poi_id = row["poi_id"]
new_item = gages_df.loc[gages_df.index == row["poi_id"], item].values[0]
poi_df.loc[idx, item] = new_item

else:
pass
if default_gages_file.exists():
Expand All @@ -317,26 +306,16 @@ def create_poi_df(
)

for idx, row in poi_df.iterrows():
if pd.isnull(row["latitude"]):
new_poi_id = row["poi_id"]
new_lat = gages_df.loc[
gages_df.index == row["poi_id"], "latitude"
].values[0]
new_lon = gages_df.loc[
gages_df.index == row["poi_id"], "longitude"
].values[0]
new_poi_agency = gages_df.loc[
gages_df.index == row["poi_id"], "poi_agency"
].values[0]
new_poi_name = gages_df.loc[
gages_df.index == row["poi_id"], "poi_name"
].values[0]

poi_df.loc[idx, "latitude"] = new_lat
poi_df.loc[idx, "longitude"] = new_lon
poi_df.loc[idx, "poi_id"] = new_poi_id
poi_df.loc[idx, "poi_agency"] = new_poi_agency
poi_df.loc[idx, "poi_name"] = new_poi_name
"""
Checks the gages_df for missing meta data and replace.
"""
columns = ["latitude", "longitude", "poi_name", "poi_agency"]
for item in columns:
if pd.isnull(row[item]):
new_poi_id = row["poi_id"]
new_item = gages_df.loc[gages_df.index == row["poi_id"], item].values[0]
poi_df.loc[idx, item] = new_item

else:
pass

Expand Down