Prevent replayable crypto tx claims and reject already-claimed transactions#82
Open
ianalloway wants to merge 1 commit into
Open
Prevent replayable crypto tx claims and reject already-claimed transactions#82ianalloway wants to merge 1 commit into
ianalloway wants to merge 1 commit into
Conversation
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
✅ Deploy Preview for aiadvantagea ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
CryptoTransactionAlreadyClaimedErrorand check for an existingcrypto:<normalizedHash>record inupsertCryptoEntitlementto reject replay attempts instead of merging/overwriting (updatednetlify/functions/_lib/entitlements.ts).txHashearly and preserve the deterministic entitlement idcrypto:<normalizedHash>while keeping the original claimant’s metadata intact (updatedupsertCryptoEntitlement).409with a clear reason instead of creating a new entitlement session andSet-Cookie(updatedapi/verify-crypto-payment.ts).netlify/functions/_lib/entitlements.test.tsthat asserts replayed transaction hashes are rejected and do not grant access to a different email.Testing
npm testand all tests passed (Test Files: 3 passed, Tests: 21 passed).npm run lintwhich completed with warnings but no errors.npm run buildwhich completed successfully.Codex Task