fix: prevent crypto payment transaction replay#83
Open
ianalloway wants to merge 1 commit into
Open
Conversation
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
✅ Deploy Preview for aiadvantagea ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
txHashandwalletAddressvalues and upserted entitlements without binding or one-time consumption, allowing replay attacks that grant paid access to arbitrary emails/devices.Description
claimCryptoEntitlement(replaces the prior upsert behavior) to normalize inputs, check for an existingcrypto:<txHash>record, and reject reuse if the existing claim does not match the same email, wallet, and tier.cryptoTxHash,walletAddress, andemailwhen no prior claim exists.api/verify-crypto-payment.tsto callclaimCryptoEntitlementfor both ETH and stablecoin paths and to set the entitlement session cookie before returning success.409response when a transaction hash has already been claimed by a different claimant, and propagate other verification errors with502as before.Testing
npm run lint; lint completed with warnings only and no errors.npm run build; the production build and prerender succeeded.Codex Task