Re-organizing test resources into packages #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #525 +/- ##
============================================
+ Coverage 77.85% 77.88% +0.03%
+ Complexity 2152 2148 -4
============================================
Files 275 275
Lines 8493 8493
Branches 807 807
============================================
+ Hits 6612 6615 +3
- Misses 1483 1486 +3
+ Partials 398 392 -6
Continue to review full report at Codecov.
|
… testcontainersFiles)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ckittl
previously requested changes
Feb 11, 2022
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTestDataMeta.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTestDataMeta.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/io/source/sql/SqlWeatherSourcePsdmIT.groovy
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Cleaning up the structure a bit more
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/test/groovy/edu/ie3/datamodel/io/source/sql/SqlTimeSeriesMappingSourceIT.groovy
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/test/groovy/edu/ie3/datamodel/io/source/sql/SqlTimeSeriesMappingSourceIT.groovy # src/test/groovy/edu/ie3/datamodel/io/source/sql/SqlWeatherSourceCosmoIT.groovy # src/test/resources/edu/ie3/datamodel/io/source/sql/_timeseries/time_series_c.sql # src/test/resources/edu/ie3/datamodel/io/source/sql/_timeseries/time_series_h.sql # src/test/resources/edu/ie3/datamodel/io/source/sql/_timeseries/time_series_p.sql # src/test/resources/edu/ie3/datamodel/io/source/sql/_timeseries/time_series_ph.sql # src/test/resources/edu/ie3/datamodel/io/source/sql/_timeseries/time_series_pq.sql # src/test/resources/edu/ie3/datamodel/io/source/sql/_timeseries/time_series_pqh.sql
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
t-ober
approved these changes
Mar 31, 2022
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: edu.ie3:PowerSystemDataModel |
sebastian-peter
dismissed
ckittl’s stale review
Fixed the last comment, I think this is fine now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #512
Resolves #559
Additional benefit: Within
CsvTestDataMeta, now all needed resources are resolved there. Before, sometimes resource directory paths were appended with suffixes, so that it wasn't checked whether the resources were actually available. Because of this, some tests did not fail that should've failed. This is now fixed.