fix(auth): remove password min_length validation from LoginRequest - #1692
Merged
imDarshanGK merged 5 commits intoJul 27, 2026
Merged
Conversation
Contributor
Author
|
@imDarshanGK I have made this changes . now all checks are passed |
imDarshanGK
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR fixes the login request validation by removing the
min_length=8constraint from theLoginRequestschema.Previously, login requests with passwords shorter than 8 characters were rejected with a 422 Unprocessable Entity response before reaching the authentication logic. Password complexity rules should only be enforced during account creation, not during login.
Changes Made
min_length=8fromLoginRequest.password.max_length=128to guard against excessively large inputs.Related Issue
Fixes #1679
Type of change
Checklist
mainpytest -v(relevant authentication tests) and all tests passfeat/fix/docs/test: short descriptionTest evidence