Skip to content

fix(auth): remove password min_length validation from LoginRequest #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imDarshanGK merged 5 commits into from
Jul 27, 2026
Merged

fix(auth): remove password min_length validation from LoginRequest #1692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44c2e5d
fix(auth): remove password min_length validation from LoginRequest
Vaishnavi10706 Jul 26, 2026
afd6a3c
style: format auth endpoint tests
Vaishnavi10706 Jul 27, 2026
580fe8b
Merge branch 'main' into fix/loginrequest-password-validation
Vaishnavi10706 Jul 27, 2026
d481603
Merge branch 'main' into fix/loginrequest-password-validation
imDarshanGK Jul 27, 2026
fbc6433
Merge branch 'main' into fix/loginrequest-password-validation
imDarshanGK Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backend/app/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,6 @@ class LoginRequest(BaseModel):
)
password: str = Field(
...,
min_length=8,
max_length=128,
description="The account password.",
example="supersecret123",
Expand Down
12 changes: 12 additions & 0 deletions backend/tests/test_auth_endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,18 @@ def test_signup_login_and_me_happy_path(client):
}


def test_login_short_password_not_rejected_by_schema(client):
response = client.post(
"/auth/login",
json={
"email": "user@example.com",
"password": "short",
},
)

assert response.status_code != 422


def test_signup_duplicate_email_returns_409(client):
payload = {"email": "dup@example.com", "password": "StrongPass123!"}
first_response = client.post("/auth/signup", json=payload)
Expand Down
Loading