-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): Add Partner Sharing Avatars to Timeline and Info Cards #12089
base: main
Are you sure you want to change the base?
Conversation
I am working on implementing a similar feature set on the web app to ensure consistent experience |
Implements |
43f5361
to
cfa784f
Compare
Cleaned up commit history and rebased to main, resolving merge conflicts. |
PR #12413 implements the same feature set on web. |
Just curious, but is this feature still not available? I haven't seen any indication of who uploaded what to a shared album. Would be a nice addition. :) |
Add settings option to show user icons on timeline Hide icons from partner image grid Replace with translatable text Remove partner sharing references in shared albums Minor improvements to phrasing in detail view
cfa784f
to
96d3706
Compare
@scrampker Just updated the PR to incorporate the changes made in the mobile app as of 1.18. Should be good to merge (pending review). Just need a maintainer to tag it and then review it :) |
- Use version that renders user's background theme and cached avatar
Hello, thank you for the PR. I just ran testing on this PR. A few points
|
Nice catch on the settings issue, and I do agree user avatar at the top is a bit out of place (since everything else up there is an action). I think there is enough context clues (like missing download and favorite icons) to indicate if an image is being shared. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@scrampker that's entirely unrelated to this PR |
This Feature adds user avatars to the timeline for both partner sharing, and shared albums. The avatar uses the user's avatar image (if one is set) or the server's information is used to make an avatar using the user's assigned color and first letter of their name.
(In the screenshot below, the partner's icon is an Orange 'T')
This is an optional configuration that adds a new setting in the Photo Grid section of the settings.

Additionally, storage information is now shown in the image details card. For partner sharing it will show which partner it belongs to. For other images, it provides a text description and existing storage icons if the photo is local, remote, or merged (backed up). This can be useful if the storage icons are hidden.