fix(web): aspect ratio for videos with 90 CW and 270 CW orientation #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
alextran1502
approved these changes
Jun 29, 2023
|
Another option is to detect a rotated image (+/- 90) and flip image height/width accordingly in the exif info. Then everything could be used as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR for #3003.
#3003 fixed the aspect ratio calculation for photos. Since
ffprobereturns other values for the orientation tag (-90,90, etc.),getAspectRatioshould handle bothexiftool-vendoredrange (1-8) andffprobevalues (-90,90,180, etc.)