-
Notifications
You must be signed in to change notification settings - Fork 301
[DDW-603] Enable pasting of wallet recovery phrase #2459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-603] Enable pasting of wallet recovery phrase #2459
Conversation
…recovery-phrase # Conflicts: # CHANGELOG.md
…f-wallet-recovery-phrase' into feature/ddw-603-enable-pasting-of-wallet-recovery-phrase
…f-wallet-recovery-phrase' into feature/ddw-603-enable-pasting-of-wallet-recovery-phrase
…lymorph - yarn lock
All of the listed issues are fixed. They are part of this PR: input-output-hk/react-polymorph#168 |
I tested this on build 17687 and on Netlify from this PR.
1 - Fixed on Netlify
2 - Can't test on Netlify, doesn't reproduce on build 17687
3 - Still reproduces on Netlify and build 17687. Check Video.
4 - Can't test on netlify, doesn't reproduce on build 17687 |
…ct-polymorph version to .21
…e react-polymorph version to .21 for qa testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fixes @aleksandardjordjeviciohk 🎉
There is just one more bug left - it is specific to the "Wallet recovery phrase verification" dialog. When you type in first character in the autocomplete a JS error is thrown.
You can get it each time you delete and enter first character in the search as shown in the following video:
bug.mp4
There was an event error onChange() method, its fixed now with these updates -> input-output-hk/react-polymorph@26e5704 |
…elease 0.9.8-rc-21
…elease 0.9.8-rc-21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now! 💯
This PR enables pasting of wallet recovery phase.
This PR will utilized changes from React Polymorph Autocomplete component from here:
input-output-hk/react-polymorph#163
Todos
Screenshots
Testing Checklist
Test Cases
Test Report
For build 17700
Fixed issues
Issues 1 to 4 were reported here.
1 - When deleting an already entered words by using "Backspace" key we should always hide the options dropdown in case it is shown (this is reproducible in develop too)
2 - When you enter the 2nd step of the "Wallet restoration" dialog, the button "Check recovery phrase" should be disabled by default (this is reproducible in develop too):
3 - When deleting already entered words by clicking on the "x" button we should prevent the options dropdown to show (this is reproducible in develop too)
4 - When pasting recovery phrase on the "Verification of the recovery phrase" dialog, there is a JS error thrown (this does not happen in the "Wallet restoration" dialog)
5 - I was able to paste more than maximum words. See screenshot
6 - After pasting words, dropdown didn't close automatically
See video
7 - When there're extra white spaces, it seemed the remaining words were not able to be pasted
See video
8 - Sometimes it is needed to click twice in the field to successfully paste values
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board