-
Notifications
You must be signed in to change notification settings - Fork 18
[DDW 603] Enable pasting of wallet recovery phrase #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW 603] Enable pasting of wallet recovery phrase #163
Conversation
…or parsing multiple strings
…g to handle only multiple values
…ues after false value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aleksandardjordjeviciohk, great work – the pasting works!
I added a few ideas how to make the logic more readable – also a few code comments could help here :)
One UX thing I noted: wasn't the idea that when you paste a series of words and one in the middle is incorrect, that this word is the last visible + the options popup shows "no results"? – at the moment only the correct words up until the first incorrect are pasted without any warning etc.
…ry phase focus + review updates
There was an issue with not doing spread of previously selected items on the selections array. I have moved that line at the proper position now and that fixed these issues. |
@gabriela-ponce @daniloprates I would like to ask you to test this one too 🙏 |
Looks good now and works as expected 🎉 |
@aleksandardjordjeviciohk Overall, it looks good. These are some edge cases that I found:
|
I have added the changes which cover this case, pls recheck @DominikGuzei |
@gabriela-ponce @DominikGuzei please review again 🙏 |
LGTM @aleksandardjordjeviciohk 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work 💯
@DominikGuzei we need your approval too 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropdown does not close when you click on a word inside of it. The old version did...
@miorsufianiohk @gabriela-ponce please re-test once @aleksandardjordjeviciohk fixes the issue I have reported here #163 (review) |
…y spaces between words
1833629
fixed |
@DominikGuzei pls review this PR once again. If all good, we need to release new version and use it here input-output-hk/daedalus#2459 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@DominikGuzei @aleksandardjordjeviciohk please merge this one and release next RP version so that we can integrate it in Daedalus 🙏 |
released as |
This PR enables pasting of wallet recovery phase.
Todos
Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board