Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding G1 robot to the simulator. A ros parameter should be passed at launch to determine which robot to swpan.
Note: one dirty trick in this code is that the lowstate and lowcmd messages of both robots are close enough so that one can be "confused" for the other and no distinction is made in the code, since the simulation wrapper fill only a few fields common to both. (EXCEPT for the foot force that is filled for the go2, but is not for the g1).
If more robot specific fields should be filled, consider refactoring this part of the code to have a clear distinction between both.
Todo: