Remove Usage of std::set in ResidencySet #547
Conversation
|
I know there are some rough aspects to this PR, but just let me know what you think of the idea. |
|
SGTM. Nice idea. |
|
Can you rebase and push? |
|
Done. Still failing. |
|
Alright, please rebase again. |
|
Cool! That did it, thanks. I like your approach, let me know when I can review. |
|
You can review. Mostly just renaming things. |
|
Re-added ResidencySet + ExecuteCommandLists ResidencySet wrapper with /deprecated tag. Please lmk if this is what you meant. |
bjjones
force-pushed
the
removeset
branch
2 times, most recently
from
21c653e to
38514ca
Compare
|
Looks good to me, thanks for fixing up the docs. FYI, the Dawn integration isn't up-streamed (obviously), so if you want to fully test you can |
|
Is D3D12ResidencyManagerTests.CreateResidencyManagerNoLeak known to be flaky? It failed but it does not appear I've made any changes that would cause it to fail. |
|
Not sure we can call it flaky yet - only 1 run failure on that patchset. Re-running it again, |
|
It flaked on GN/MSVC Debug initially, then passed: |
|
Good catch, filed #553 |
Removes usage of std::set in ResidencySet and replaces it with a vector. This does allow duplicat heaps to be inserted into the ResidencySet, however insertion will be O(1) instead of O(log(n)) and instead we can easily identify duplicate heaps by checking their last used fence value when when they are iterated.
Removes usage of std::set in ResidencySet and replaces it with a std::vector.
This does allow duplicate heaps to be inserted into the ResidencySet,
however insertion will be O(1) instead of O(log(n)) and instead we can
easily identify duplicate heaps by checking their last used fence value
when during iteration.