build: remove requeriment to have a recent autoconf-archive #911
Conversation
gorozco1
changed the title
gorozco1
changed the title
gorozco1
changed the title
gorozco1
force-pushed
the
m4-version-revert
branch
from
c23a22a to
a6e1cd3
Compare
gorozco1
changed the title
|
It is need to call to AX_VALGRIND_DFLT before AX_VALGRIND_CHECK |
| ]) | ||
|
|
||
| MACRO_CHECK([AX_VALGRIND_DFLT]) |
There was a problem hiding this comment.
This macro will check for AX_VALGRIND_CHECK AX_CODE_COVERAGE that are provided by autoconf archive.
I wonder if we can modify MACRO_CHECK, to not fail de execution but let us know if the AX_VALGRIND_CHECK and others are defined.
If they are defined the m4 files exist and we could use valgrind and code coverage, otherwise we continue with the execution without execute valgrind test.
There was a problem hiding this comment.
Hi @jcvenegas - I agree that that would be a nice optimisation but I don't think that needs to block this PR (since we already fail if the expected version of autoconf-archive isn't installed). Could you raise an issue to capture the idea maybe?
There was a problem hiding this comment.
agree @jodh-intel , docuemented in #917, lets merge this change
|
@jcvenegas I think the AX_VALGRIND_DFLT is used for setting the defaults, in our case never running the sgcheck tool. We can get away with this by passing --disable-valgrind-sgcheck to configure. |
|
qa-failed |
|
got these lines: |
|
@amshinde thanks for clarify , so adding adding --disable-valgrind-sgcheck should fix that issue. |
This reverts commit a210cc4. Signed-off-by: Geronimo Orozco <[email protected]>
gorozco1
force-pushed
the
m4-version-revert
branch
3 times, most recently
from
f94fbbd to
81abf0f
Compare
|
qa-failed |
1 similar comment
|
qa-failed |
|
I think @chavafg should add |
|
The failures is happening on with the |
|
qa-failed |
gorozco1
force-pushed
the
m4-version-revert
branch
from
81abf0f to
0f92144
Compare
|
qa-passed |
|
\o/ |
| @@ -29,7 +29,8 @@ autoreconf --force --install --symlink --warnings=all | |||
| args="\ | |||
| --sysconfdir=/etc \ | |||
| --localstatedir=/var \ | |||
| --prefix=/usr" | |||
| --prefix=/usr \ | |||
| --disable-valgrind-sgcheck" | |||
There was a problem hiding this comment.
I see that this change will automatically be applied to the OBS builds, since the files in data/obs-packaging/ call ./autogen.sh.
| ]) | ||
|
|
||
| MACRO_CHECK([AX_VALGRIND_DFLT]) |
There was a problem hiding this comment.
Hi @jcvenegas - I agree that that would be a nice optimisation but I don't think that needs to block this PR (since we already fail if the expected version of autoconf-archive isn't installed). Could you raise an issue to capture the idea maybe?
|
lgtm |
|
@rcaballeromx could you review this change? |
AX_VALGRIND_DFLT makes it imposible to build cc-oci-runtime in older distros. Hence we need to disable this checks in order to build successfuly on Ubuntu 16.04, Ubuntu 16.10 and Fedora 24. Added --disable-valgrind-sgcheck to default build options Fixes intel#888 and intel#887 Signed-off-by: Geronimo Orozco <[email protected]>
gorozco1
force-pushed
the
m4-version-revert
branch
from
0f92144 to
161aa5c
Compare
|
lgtm |
cc-oci-runtime OBS builds needed 2 patches to build successfully on Ubuntu 16.04, Ubuntu 16.10 and F24. These patches already have been sent to the oficial repo on PR intel#911 Besides these patches, this commit adds improvements to the OBS automation tooling for cc-oci-runtime, and the updated changelog sent to the OBS builds. Signed-off-by: Geronimo Orozco <[email protected]>
cc-oci-runtime OBS builds needed 2 patches to build successfully on Ubuntu 16.04, Ubuntu 16.10 and F24. These patches already have been sent to the oficial repo on PR intel#911 Besides these patches, this commit adds improvements to the OBS automation tooling for cc-oci-runtime, and the updated changelog sent to the OBS builds. Signed-off-by: Geronimo Orozco <[email protected]>
|
qa-passed |
Asking for a recent autoconf-archive makes it extra difficult to build cc-oci-runtime in older distros: Ubuntu 16.04, Ubuntu 16.10 Fedora 24.
With this patch I am removing the requeriment for a recent autoconf-archive as well as references to AX_VALGRIND_DFLT.
Added --disable-valgrind-sgcheck to default build options
Fixes #888 and #887