Skip to content
This repository was archived by the owner on Mar 28, 2018. It is now read-only.

Docs: metrics: network: Clarify pre-process and running #946

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

grahamwhaley
Copy link

Correct the typo in the network metrics build command, and clarify
how the tests can be run by hand after pre-processing.

Fixes: #944

Signed-off-by: Graham Whaley [email protected]

Correct the typo in the network metrics build command, and clarify
how the tests can be run by hand after pre-processing.

Signed-off-by: Graham Whaley <[email protected]>
@jodh-intel
Copy link
Contributor

jodh-intel commented Jun 5, 2017

lgtm

Approved with PullApprove

@chavafg
Copy link
Contributor

chavafg commented Jun 5, 2017

qa-passed

Approved with PullApprove

@grahamwhaley
Copy link
Author

Hi @jodh-intel @gorozco1 Looks like Travis is failing as the curl of the autoconf archive is giving a 502 Bad Gateway error. Not sure if that is a temporary or permanent issue - any thoughts?
If you try the url:
http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_valgrind_check.m4
then what I see in the logs is a 193 byte download instead of a 8852 byte download - that was the clue ;-)

@jodh-intel
Copy link
Contributor

Hi @grahamwhaley - it does indeed look like that site is borked atm (you can't even download via cvs).

I think we might want to rethink our approach for obtaining autoconf-archive (#876 (review)). It's "overkill" to download the whole archive when we only want 2 files, but if we're pulling a stable release, not only do we know which version of the code we're actually using, but we have more choices wrt a reliable download site due to large number of available mirrors.

@jodh-intel
Copy link
Contributor

... alternatively, we could just enable https://docs.travis-ci.com/user/caching/ so that once we have a good copy, we'll continue to use that.

@GabyCT
Copy link
Contributor

GabyCT commented Jun 5, 2017

lgtm

Approved with PullApprove

Copy link

@iphutch iphutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a docs team perspective.

@jodh-intel jodh-intel merged commit 136c7ed into intel:master Jun 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants