[libspirv] use generic isfinite/isinf/isnan for NVPTX#22413
Open
wenju-he wants to merge 2 commits into
Open
Conversation
Motivation is to delete include/libspirv/relational.h. Generic implementations are better for nvptx: - IsFinite: fully vectorized; elimiates fpext and __nv_isfinited calls. - IsInf: vectorized icmp and ext. - IsNan: fully vectorized; elimiates __nv_isnan calls.
wenju-he
added a commit
to llvm/llvm-project
that referenced
this pull request
Jun 25, 2026
The file calls __nv_isinf which return 1 for true on vector input, while the generic clc_isinf which return -1 for true on vector input. Using nvptx clc_isinf in OpenCL isinf violates OpenCL spec. Found the issue in intel/llvm#22413
llvm-sync Bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jun 25, 2026
…699) The file calls __nv_isinf which return 1 for true on vector input, while the generic clc_isinf which return -1 for true on vector input. Using nvptx clc_isinf in OpenCL isinf violates OpenCL spec. Found the issue in intel/llvm#22413
llvm-upstreamsync Bot
pushed a commit
to qualcomm/cpullvm-toolchain
that referenced
this pull request
Jun 25, 2026
…699) The file calls __nv_isinf which return 1 for true on vector input, while the generic clc_isinf which return -1 for true on vector input. Using nvptx clc_isinf in OpenCL isinf violates OpenCL spec. Found the issue in intel/llvm#22413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation is to delete include/libspirv/relational.h.
Delete wrong implementation nvptx/relational/clc_isinf.cl, which returns 1 for true in vector input,
while the generic clc_isinf.cl is conforming to OpenCL spec.
Generic implementations are better for nvptx: