-
Notifications
You must be signed in to change notification settings - Fork 59
Fix ProcessGroupXCCL options initialization #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the initialization order of ProcessGroupXCCL options to ensure the group UID is set before creating the log prefix. The key changes include reordering the member initialization list and moving the setGroupUid call before createLogPrefix().
- Moved
options_initialization afterlocal_id_in the member initialization list - Relocated
setGroupUidcall to execute beforecreateLogPrefix()
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream PR will cause options to be properly set.
@frost-intel, can you, please, clarify how your PR relates with the upstream PR mentioned above? Is upstream PR a prerequisite to this one or vice versa? i.e. which one should be merged first or they are independent?
|
@dvrogozh Both PRs are necessary to fix a specific bug, where the ProcessGroupXCCL::Options was not being set properly when passed as an argument. However, the two PRs are not dependent on each other. There are two different bugs which have the same effect. The upstream PR fixes the issue of Options not being writable, and this PR fixes a problem with the initialization list order and the proper value not being set before it was used by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group UID needs to be set before creating the LogPrefix, and the initialization list order is fixed now.
Upstream PR will cause options to be properly set.