Skip to content

Fix ProcessGroupXCCL options initialization #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix ProcessGroupXCCL options initialization #2203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e1d4d6
Fix pgxccl options initialization
frost-intel Oct 21, 2025
5219481
Update src/xccl/ProcessGroupXCCL.cpp
frost-intel Oct 21, 2025
04335cf
Merge branch 'main' into frost/pgxccl_options
frost-intel Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/xccl/ProcessGroupXCCL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,14 +370,14 @@ ProcessGroupXCCL::ProcessGroupXCCL(
c10::intrusive_ptr<Options> options)
: Backend(rank, size),
store_(store),
Copy link
Contributor

@guangyey guangyey Oct 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use std::move here?

options_(std::move(options)),
xcclCommCounter_(0),
local_id_(process_group_id++) {
local_id_(process_group_id++),
options_(std::move(options)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know if the order of options_ doesn't matter here, I guess yes.

this->setGroupUid(options_->group_name);
logPrefix_ = createLogPrefix();
blockingWait_ = getCvarBool(TORCH_XCCL_BLOCKING_WAIT, false);
traceBufferSize_ = getCvarInt({"TORCH_FR_BUFFER_SIZE"}, 2000);

this->setGroupUid(options_->group_name);
// In PGNCCL, the pg ranks are recorded on comm setup in each op, but we just
// do it here.
const auto XcclVersion = getXcclVersion();
Expand Down
Loading