fix: improve callback safety in WebSocket and DataChannel wrappers #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the implementation to match the latest libdatachannel with features for setting ICE ufrag/pwd, reading the remote cert fingerprint and receiving callbacks for unhandled mux requests. Also adds pass-through for missing config values.
Just pass Uint8Arrays in
achingbrain
requested changes
Apr 12, 2025
There was a problem hiding this comment.
Thanks for opening this. This repo is a temporary fork of node-datachannel that incorporates murat-dogan/node-datachannel#256
To avoid this repo getting too out of sync with the upstream repo, please can you PR your changes to murat-dogan/node-datachannel then we'll integrate them here after merge.
achingbrain
force-pushed
the
master
branch
9 times, most recently
from
b2011d2 to
a72f076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance callback safety and memory management
Improve callback handling and memory safety in WebSocket and DataChannel wrappers by replacing dangerous reference captures with value captures and implementing weak_ptr pattern for safe object lifetime tracking. Add std::enable_shared_from_this for proper shared pointer support across the wrapper classes. Address potential use-after-free issues in callbacks and enhance thread safety through proper pointer management and callback lifetime handling. These changes significantly reduce the risk of dangling references and memory-related issues in asynchronous operations.