Adds a CI job for testing code changes against known samples on the m…#38
Conversation
Summary of ChangesHello @jeFF0Falltrades, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a foundational testing pipeline for the main repository by integrating a new CI job. The primary goal is to ensure the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a CI job to test code changes against a suite of known samples, which is a great step towards ensuring the parser's reliability. The changes include adding test dependencies, version bumping, and creating the test suite itself along with expected outputs. The test implementation is robust, with good use of pytest features for parameterization and conditional skipping. I have one suggestion to make the code for finding sample files more concise and Pythonic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ain repo
Going to test this out as an initial stab at having a test pipeline at the very least for the main repository.
It includes a test suite and an encrypted ZIP of known samples that I would rather not propagate via the repo plainly, so the CI job is set up to decrypt and test against these only for PRs that are being merged or sourced from the main repo itself (though the hashes are plain to see if other researchers wish to download and test against them).
We'll adjust this as needed.