Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #10437 - Unify Deployer ContextProvider #12583

Open
wants to merge 104 commits into
base: jetty-12.1.x
Choose a base branch
from
Open

Issue #10437 - Unify Deployer ContextProvider #12583

wants to merge 104 commits into from

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Nov 26, 2024

A single scanner for all Environments.
Environment attributes are how the environment specific deployment configuration is controlled.
Existing properties behaviors maintained.

Currently a WIP (needs more testing and documentation)

@joakime joakime added Enhancement Bug For general bugs on Jetty side labels Nov 26, 2024
@joakime joakime requested a review from sbordet November 26, 2024 21:48
@joakime joakime self-assigned this Nov 26, 2024
@joakime joakime changed the base branch from jetty-12.0.x to jetty-12.1.x November 26, 2024 21:48
@joakime joakime linked an issue Nov 26, 2024 that may be closed by this pull request
Review DeploymentManager and ScanningAppProvider #10437
Open
@joakime joakime marked this pull request as ready for review December 3, 2024 00:01
@janbartel janbartel requested a review from gregw December 10, 2024 04:35
sbordet
sbordet requested changes Dec 10, 2024
View reviewed changes
...loy/src/test/java/org/eclipse/jetty/deploy/providers/ContextProviderDeferredStartupTest.java Outdated Show resolved Hide resolved
...ploy/src/test/java/org/eclipse/jetty/deploy/providers/ContextProviderRuntimeUpdatesTest.java Outdated Show resolved Hide resolved
...etty-deploy/src/test/java/org/eclipse/jetty/deploy/providers/ContextProviderStartupTest.java Outdated Show resolved Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/Deployable.java Outdated Show resolved Hide resolved
jetty-ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/WebAppContext.java Outdated Show resolved Hide resolved
jetty-core/jetty-deploy/src/main/java/org/eclipse/jetty/deploy/providers/ContextProvider.java Outdated Show resolved Hide resolved
jetty-core/jetty-deploy/src/main/java/org/eclipse/jetty/deploy/providers/ContextProvider.java Outdated Show resolved Hide resolved
jetty-core/jetty-deploy/src/main/java/org/eclipse/jetty/deploy/providers/ContextProvider.java Outdated Show resolved Hide resolved
jetty-core/jetty-deploy/src/main/config/etc/jetty-deployment-manager.xml Outdated Show resolved Hide resolved
jetty-core/jetty-deploy/src/main/config/modules/deployment-manager.mod Outdated Show resolved Hide resolved
@sbordet
Copy link
Contributor

sbordet commented Dec 10, 2024 •
edited
Loading

I'd like to see:

  • alphabetical sort of scanned files
  • DeploymentManager does not need to know AppProviders. It's AppProviders that call the DeploymentManager to deploy Apps. AppProviders can just be added as beans to DeploymentManager
  • Documentation
  • ContextProvider renamed to something more telling. DeploymentScanningAppProvider? The word "Context" has no meaning in this class, and it is lost in the current class name that it is a ScanningAppProvider.

joakime added 14 commits February 3, 2025 11:09
@joakime joakime mentioned this pull request Feb 5, 2025
Open
@joakime
Copy link
Contributor Author

joakime commented Feb 5, 2025

This is ready to review again.
Note: the 2 test failures seem to be flakes, they are unrelated to the changes in this branch.

@joakime joakime mentioned this pull request Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbartel janbartel janbartel requested changes

@firoj0 firoj0 firoj0 left review comments

@gregw gregw gregw requested changes

@sbordet sbordet Awaiting requested review from sbordet

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side build-all-tests Enhancement
Projects
Jetty 12.1.0
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review DeploymentManager and ScanningAppProvider
5 participants
@joakime @sbordet @gregw @janbartel @firoj0