fix: use spatialgeometry's renamed Polyline instead of deprecated Path - #120
Merged
Merged
Conversation
spatialgeometry renamed the Python class Path -> Polyline (avoids clashing with pathlib.Path -- jhavl/spatialgeometry#42), keeping Path as a deprecated (FutureWarning) alias. Migrates swift's one direct reference (test_protocol.py). The wire-protocol stype string deliberately stays "path" -- changing that too would be a breaking protocol change for a rename that's purely cosmetic on the Python side -- so shapes.js needed comments explaining the naming disparity, not a code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spatialgeometry renamed the Python class
Path->Polyline(avoids clashing withpathlib.Path-- jhavl/spatialgeometry#42), keepingPatharound as a deprecated (FutureWarning) alias.Migrates swift's one direct reference to the old name (
tests/test_protocol.py). The wire-protocolstypestring deliberately stays"path"-- changing that too would be a breaking protocol change requiring a matchingshapes.jsupdate, for a rename that's purely cosmetic on the Python side -- soshapes.jsjust gained comments explaining the naming disparity at both the class-level doc comment and thestype === "path"dispatch site, not a code change.Test plan
FutureWarningfires anymore: reran the affected test with-W error::FutureWarning, still passes🤖 Generated with Claude Code