refactor: server should start the receive loop #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2024
kalbasit
force-pushed
the
graphite-base/19
branch
from
190990d to
180e9ab
Compare
kalbasit
force-pushed
the
server-should-start-receive-loop
branch
from
2e6210d to
5462eb5
Compare
ref #8 Co-authored-by: Mathias Fredriksson <[email protected]>
kalbasit
force-pushed
the
server-should-start-receive-loop
branch
from
5462eb5 to
dd65e22
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the receive loop into the server package and make it restart on error
The receive loop is now managed by the server package, which will restart it automatically if it encounters an error. The loop previously lived in main.go but has been relocated to server.go for better error handling and recovery.
ref #8
Co-authored-by: Mathias Fredriksson [email protected]