refactor(server): Break up ServeHTTP for readability #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Extracted HTTP handlers for
/receive/pop
and/receive/flush
endpoints into separate methods.What changed?
/receive/pop
handler logic intoreceivePop
method/receive/flush
handler logic intoreceiveFlush
method//nolint:nestif
comment as it's no longer neededServeHTTP
method now delegates to these new methodsHow to test?
/receive/pop
endpoint/receive/flush
endpointWhy make this change?
Improves code organization and readability by breaking down the large
ServeHTTP
method into smaller, focused methods. This makes the code easier to maintain and test while reducing cognitive complexity.