[dotfiles-improvement] perf: replace grep -q here-string with ZSH built-in pattern matching - #533
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
Replace `grep -q "literal" <<< "\$var"` with `[[ "\$var" == *pattern* ]]` in macos-notvscode.zsh (4 occurrences) and aliases/go.zsh (1 occurrence). ZSH built-in string matching requires no subshell or external process, making these checks faster and more portable. Affected functions: - is-at-home (macos-notvscode.zsh): 2 occurrences - is-displaylink-connected (macos-notvscode.zsh): 2 occurrences - golangci-lint-with-retry (aliases/go.zsh): 1 occurrence Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Five places across two files use
grep -q "literal" <<< "$var"to test if a variable contains a substring:Change
Replace with ZSH's built-in glob pattern matching:
[[ var == *pattern* ]]is a ZSH built-in that does substring matching without spawning a subshell or forkinggrep. Semantically equivalent for literal string checks.Affected locations (5 occurrences)
zsh/macos-notvscode.zsh—is-at-home(2 occurrences),is-displaylink-connected(2 occurrences)zsh/aliases/go.zsh—golangci-lint-with-retry(1 occurrence)No behavior change
Literal substring matching is identical between
grep -qand[[ == *pattern* ]].