Skip to content

[dotfiles-improvement] perf: replace grep -q here-string with ZSH built-in pattern matching #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[dotfiles-improvement] perf: replace grep -q here-string with ZSH built-in pattern matching #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zsh/aliases/go.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ golangci-lint-with-retry() {
if output=$(golangci-lint run --fix 2>&1); then
echo "$output"
return 0
elif grep -q "parallel golangci-lint is running" <<< "$output"; then
elif [[ "$output" == *"parallel golangci-lint is running"* ]]; then
echo "Attempt $attempt/$max_attempts: Waiting for parallel golangci-lint to finish..."
sleep 1
((attempt++))
Expand Down
8 changes: 4 additions & 4 deletions zsh/macos-notvscode.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@ is-at-home() {
[[ "$OSTYPE" != darwin* ]] && return 1
local usb_info
usb_info=$(ioreg -p IOUSB) &&
grep -q "Plugable USBC-6950U" <<< "$usb_info" &&
grep -q "TS4" <<< "$usb_info" &&
[[ "$usb_info" == *"Plugable USBC-6950U"* ]] &&
[[ "$usb_info" == *TS4* ]] &&
networksetup -getnetworkserviceenabled "Thunderbolt Ethernet Slot 2" | grep -q Enabled
}
is-displaylink-connected() {
[[ "$OSTYPE" != darwin* ]] && return 1
local display_info
display_info=$(system_profiler SPDisplaysDataType)
grep -q "ARZOPA" <<< "$display_info" ||
grep -q "TYPE-C" <<< "$display_info"
[[ "$display_info" == *ARZOPA* ]] ||
[[ "$display_info" == *TYPE-C* ]]
}
restart-displaylink() {
if [[ "$OSTYPE" != darwin* ]]; then
Expand Down