Insert newlines after streaming tool results #770
Conversation
|
Thanks for the PR. This is trickier than it appears. I need to test some edge cases when I can before merging. |
jdormit
force-pushed
the
jdormit/streaming-tool-result-newline
branch
from
d6b4335 to
f55fe33
Compare
|
Think I've run into one of those edge cases you were talking about @karthink: we should really be inserting the separator before a chat response, rather than after a tool response - otherwise multiple tool calls in a row leads to a bunch of newlines. Not sure if I'll have time to tackle that today but should be able to soon-ish. |
jdormit
force-pushed
the
jdormit/streaming-tool-result-newline
branch
from
f55fe33 to
f36fb33
Compare
| @@ -266,6 +266,9 @@ Optional RAW disables text properties and transformation." | |||
| (set-marker-insertion-type tracking-marker t) | |||
| (plist-put info :tracking-marker tracking-marker)) | |||
| (goto-char tracking-marker) | |||
| (when (plist-get info :last-was-tool-result) | |||
| (insert gptel-response-separator) | |||
There was a problem hiding this comment.
Here's another edge case.
When you test Claude it usually responds with text ("I'll run this tool for you"), then a tool call, then more text ("The results of the tool are X"). This fix works fine for those cases.
Suppose the LLM responds instead with a tool call followed by a response, as Gemini and OpenAI models do. (No preamble before the tool call.)
Then you get a response that looks like this (with response-prefix Response: )
User: What is the time in Greece?
Response:
The time in Greece is ...instead of
User: What is the time in Greece?
Response: The time in Greece is...
The extra gptel-response-separator between Response: and the result is from your :last-was-tool-call tracking.
|
Also, a similar fix might be needed for non-streaming responses. |
jdormit
force-pushed
the
jdormit/streaming-tool-result-newline
branch
from
f36fb33 to
7672ab9
Compare
jdormit
force-pushed
the
jdormit/streaming-tool-result-newline
branch
from
7672ab9 to
e45bcec
Compare
jdormit
force-pushed
the
jdormit/streaming-tool-result-newline
branch
from
e45bcec to
7476897
Compare
jdormit
force-pushed
the
jdormit/streaming-tool-result-newline
branch
from
7476897 to
a3493ad
Compare
|
@jdormit I see a couple of new commits from you here. Is the edge case from my comment above handled now? |
This is a fix for #769. It ensures that we insert a
gptel-response-separatorafter a tool result comes in in streaming mode. This prevents weird formatting whengptel-include-tool-resultsisniland the tool result came in between two chat responses (see the linked issue for details).