-
Notifications
You must be signed in to change notification settings - Fork 287
Insert newlines after streaming tool results #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jdormit
wants to merge
26
commits into
karthink:master
Choose a base branch
from
jdormit:jdormit/streaming-tool-result-newline
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a3493ad
Insert newlines after streaming tool results
jdormit 0ad659c
gptel-rewrite: Clear and restore overlay face around ediff
karthink e075972
openai-extras: Refine reasoning block detection for Deepseek
karthink 2238f45
gptel-transient: Add log level and inspect log options
karthink 3665dae
gptel: Ensure zero-arg tools have valid parameters struct
tazjin 13b954b
gptel: Add AI/ML API Integration (#930)
D1m7asis 3e57fe2
gptel-rewrite: Use plain window setup in ediff
karthink 78d56e6
gptel-gemini: Construct request data without backquotes
karthink 7b94cd5
gptel-openai: Appease byte-compiler (#945)
karthink e0f6398
Use git to produce better merge conflicts for rewrite
meain ba2ab53
rewrite: Refactor merge conflict handling to not use strings
karthink 178d1bf
README: Add gptel-commit to related projects (#944)
lakkiy dc126ff
gptel-org: Update docstring for clarity (#936)
rgkirch 4cfce86
gptel-gemini: Add gemini-2.5 pro, flash and flash-lite (#926)
stribb ae720af
README: Mention more packages using gptel
karthink aad5ced
gptel-org: Set org-complex-heading-regexp in prompt buffer
karthink d72871c
gptel-curl: Fix text handling around end of reasoning block
karthink 703428e
gptel: Fix warnings for :pre and :post in a preset (#952)
kmontag c20ca5c
gptel: Add copy Curl command feature to dry-run
karthink bdf19df
README: Add setup instructions for Open WebUI (#954)
algal 9a4927e
gptel: Add JSON response schema parsing and preprocessing
karthink f0205da
gptel: Add JSON output for OpenAI, Anthropic, Gemini, Ollama
karthink afceb1b
gptel: Update comments, indentation and test submodule
karthink be391ab
gptel-transient: Fix log-level selection menu (#960)
nano-o cac22aa
gptel-openai: Don't parse tools named "null" (#935) (#951)
timfel 26e3dac
gptel: Include full file path in context (#863)
karthink File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's another edge case.
When you test Claude it usually responds with text ("I'll run this tool for you"), then a tool call, then more text ("The results of the tool are X"). This fix works fine for those cases.
Suppose the LLM responds instead with a tool call followed by a response, as Gemini and OpenAI models do. (No preamble before the tool call.)
Then you get a response that looks like this (with response-prefix
Response:
)User: What is the time in Greece? Response: The time in Greece is ...
instead of
The extra
gptel-response-separator
betweenResponse:
and the result is from your:last-was-tool-call
tracking.