Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.17] Not just render oidc env-vars when cfg is on, we need also a present audience to ensure the camel containers work correct #8459

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #8448


…audience to ensure the camel containers work correct

Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi February 13, 2025 06:37
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
Copy link

knative-prow bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (93cc440) to head (6f4d655).
Report is 1 commits behind head on release-1.17.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.17    #8459      +/-   ##
================================================
- Coverage         64.10%   64.09%   -0.01%     
================================================
  Files               388      388              
  Lines             23406    23408       +2     
================================================
- Hits              15004    15003       -1     
- Misses             7603     7605       +2     
- Partials            799      800       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit a017fc0 into knative:release-1.17 Feb 13, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants