Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy new monitoring stack #3360

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Deploy new monitoring stack #3360

merged 3 commits into from
Jun 3, 2022

Conversation

@knative-prow knative-prow bot requested a review from krsna-m June 2, 2022 20:13
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@krsna-m
Copy link
Contributor

krsna-m commented Jun 3, 2022

Thanks for tackling this one. With these new changes we probably don't need https://github.com/knative/test-infra/tree/main/prow/cluster/monitoring anymore and that can be safe to remove.

@krsna-m
Copy link
Contributor

krsna-m commented Jun 3, 2022

cc @chizhg if you are interested :)

@upodroid
Copy link
Member Author

upodroid commented Jun 3, 2022

With these new changes we probably don't need https://github.com/knative/test-infra/tree/main/prow/cluster/monitoring anymore and that can be safe to remove.

I'll remove it in a separate PR. I'm not quite happy with the Managed Prometheus and GCP Monitoring integration. I'll most likely end up deploying a public grafana instance with a selection of those dashboards.

@krsna-m
Copy link
Contributor

krsna-m commented Jun 3, 2022

+1 to the hosted monitoring. There was some concern about the managed price.
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
@knative-prow knative-prow bot merged commit d577301 into knative:main Jun 3, 2022
@upodroid
Copy link
Member Author

upodroid commented Jun 3, 2022

+1 to the hosted monitoring. There was some concern about the managed price.

I'll keep an eye on the costs. Managed Prometheus pricing was discounted recently. (IMHO it was overpriced and I was part of the private preview). It saves a lot of operational work with running Prometheus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants