Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sig node test approvers (and sync the OWNER_ALIASES) #34280

Merged

Conversation

SergeyKanzhelev
Copy link
Member

When syncing the OWNER_ALIASES (first commit) I found a few problems:

The group sig-contributor-experience-technical-leads is used in the repository, but not defined in http://git.k8s.io/community/OWNERS_ALIASES.

The group provider-openstack is from CUSTOM CONTENT has a different set of people than in the CUSTOM CONTENT in http://git.k8s.io/community/OWNERS_ALIASES.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/testgrid sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 5, 2025
@SergeyKanzhelev
Copy link
Member Author

Lot's of copy paste and I think expanded some groups of people. I would appreciate thorough review and I am sorry for any unintended mistake I could have made when copying

@SergeyKanzhelev
Copy link
Member Author

/assign @pohly

@kannon92
Copy link
Contributor

kannon92 commented Feb 6, 2025

One minor issue: #34280 (comment)

Looking at owners files,
/assign @BenTheElder @aojea

@BenTheElder
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2025
@BenTheElder
Copy link
Member

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2025
@BenTheElder
Copy link
Member

My comment about the problems with heavy usage of aliases stands, but is not blocking: #34280 (comment)

@BenTheElder
Copy link
Member

(they were originally used for things like SIG leads as stop-gap fallback owners, NOT as the primary way to list owners and therefore make it difficult to understand who owns these, new contributors will have never seen OWNERS file and indirecting to quasi github-groups that aren't github groups is even more confusing if you don't already know deeply about this Kubernetes-specific tooling)

@k8s-ci-robot k8s-ci-robot merged commit c060083 into kubernetes:master Feb 7, 2025
5 checks passed
@SergeyKanzhelev SergeyKanzhelev deleted the sigNodeTestApprovers branch February 7, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

6 participants