-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sig node test approvers (and sync the OWNER_ALIASES) #34280
Sig node test approvers (and sync the OWNER_ALIASES) #34280
Conversation
Lot's of copy paste and I think expanded some groups of people. I would appreciate thorough review and I am sorry for any unintended mistake I could have made when copying |
/assign @pohly |
One minor issue: #34280 (comment) Looking at owners files, |
44cb7bc
to
55ec7d7
Compare
/hold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
My comment about the problems with heavy usage of aliases stands, but is not blocking: #34280 (comment) |
(they were originally used for things like SIG leads as stop-gap fallback owners, NOT as the primary way to list owners and therefore make it difficult to understand who owns these, new contributors will have never seen OWNERS file and indirecting to quasi github-groups that aren't github groups is even more confusing if you don't already know deeply about this Kubernetes-specific tooling) |
When syncing the OWNER_ALIASES (first commit) I found a few problems:
The group
sig-contributor-experience-technical-leads
is used in the repository, but not defined in http://git.k8s.io/community/OWNERS_ALIASES.The group
provider-openstack
is from CUSTOM CONTENT has a different set of people than in the CUSTOM CONTENT in http://git.k8s.io/community/OWNERS_ALIASES.