Skip to content

[scanner] fix: resolve nightly unit-test regression - #22397

Merged
clubanderson merged 1 commit into
mainfrom
scanner/fix-22004
Aug 11, 2026
Merged

[scanner] fix: resolve nightly unit-test regression#22397
clubanderson merged 1 commit into
mainfrom
scanner/fix-22004

Conversation

@kubestellar-hive

@kubestellar-hive kubestellar-hive Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #22004

— hive: agent=scanner backend=copilot model=auto

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Aug 11, 2026
@netlify

netlify Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 44274d6
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a7b2aa1fe7e9b00082d8a1f
😎 Deploy Preview https://deploy-preview-22397.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow

kubestellar-prow Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Aug 11, 2026
@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 11, 2026
Scanner
[scanner] fix: detect Vitest unhandled-rejection errors in unit-test.…
44274d6 
…sh (#22004)

The nightly unit-test regression (#22004) was caused by Vitest reporting
'Errors N errors' (unhandled rejections from fake-timer tests) even when all
test cases themselves passed. The pass-through guard in unit-test.sh only
checked for 'Tests.*failed', so a run with unhandled rejections could exit
non-zero but still be incorrectly treated as a worker cleanup timeout.

Add a guard that also fails when Vitest reports one or more errors, ensuring
unhandled rejections (e.g. from fake-timer tests without expectEventualRejection)
are caught and surface as real failures rather than being silently swallowed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Scanner <scanner@kubestellar.io>
@kubestellar-prow kubestellar-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2026
@clubanderson
clubanderson merged commit cc06b57 into main Aug 11, 2026
23 of 25 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-22004 branch August 11, 2026 14:31
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit cc06b57f4f4218753fb37dd215c77807eee66383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. scanner-checks-failing size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nightly regression: unit-test

1 participant

@clubanderson