Skip to content

[scanner] fix: resolve nightly unit-test regression #22397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clubanderson merged 1 commit into from
Aug 11, 2026
+4 −1
Merged

[scanner] fix: resolve nightly unit-test regression #22397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/unit-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ fi

if [ "$EXIT_CODE" -ne 0 ]; then
# Check if all tests actually passed despite the non-zero exit
if grep -q "Tests.*passed" "$OUTPUT_FILE" && ! grep -q "Tests.*failed" "$OUTPUT_FILE"; then
# Also guard against Vitest reporting "Errors N errors" (unhandled rejections)
# even when no test cases failed — those errors caused the nightly regression in
# #22004 and must not be silently swallowed. (#22004)
if grep -q "Tests.*passed" "$OUTPUT_FILE" && ! grep -q "Tests.*failed" "$OUTPUT_FILE" && ! grep -qE "Errors +[1-9][0-9]* errors" "$OUTPUT_FILE"; then
# All tests passed — exit was likely a pool worker termination timeout
echo ""
echo "All tests passed (exit code $EXIT_CODE was a non-test error, e.g. worker cleanup timeout)"
Expand Down
Loading