Use `mesheryctl` to deploy service meshes #25

s1ntaxe770r · 2021-11-18T06:50:45Z

Signed-off-by: Jubril Oyetunji [email protected]

Description
I added a bash script to check if mesheryctl is installed and deploy a service mesh
This PR fixes #
#20
Notes for Reviewers

Signed commits

Yes, I signed my commits.

Signed-off-by: Jubril Oyetunji <[email protected]>

Aisuko

Thanks for contributing, please take a look the comment below.

Aisuko · 2021-11-18T07:29:19Z

.github/workflows/scripts/mesh_deploy.sh

+if mesheryctl
+
+then
+	echo found mesheryctl, deploying $MESH


Is there we need add "?

Aisuko · 2021-11-18T07:30:05Z

.github/workflows/scripts/mesh_deploy.sh

+
+then
+	echo found mesheryctl, deploying $MESH
+	mesheryctl mesh deploy $mesh


Aisuko · 2021-11-18T07:33:12Z

.github/workflows/scripts/mesh_deploy.sh

+
+install_mesheryctl(){
+  curl -L https://github.com/meshery/meshery/releases/download/v0.5.67/mesheryctl_0.5.67_Linux_x86_64.zip -o mesheryctl.zip
+  unzip -n mesheryctl.zip 


Is there any reason we shouldn't overwrite the existing files?

Aisuko · 2021-11-18T07:33:52Z

.github/workflows/scripts/mesh_deploy.sh

@@ -0,0 +1,27 @@
+MESH=$1
+
+echo "checking if mesheryctl is installed"


Cheking would be good.

Aisuko · 2021-11-18T07:41:02Z

.github/workflows/scripts/mesh_deploy.sh

+install_mesheryctl(){
+  curl -L https://github.com/meshery/meshery/releases/download/v0.5.67/mesheryctl_0.5.67_Linux_x86_64.zip -o mesheryctl.zip
+  unzip -n mesheryctl.zip 
+  mv mesheryctl /usr/local/bin/mesheryctl


If I remember right, there would be a permission issue? Maybe there is other solution here?https://unix.stackexchange.com/questions/37724/permissions-ownership-of-usr-local-bin

🤔 I'm not sure, as far as I know, workflow runners usually run as a privileged user

Sounds good. We don't need to change this.

If you use the approved installation procedure, this is already considered for.

// @hexxdump

Signed-off-by: Jubril Oyetunji <[email protected]>

leecalcote · 2021-11-18T14:21:15Z

.github/workflows/scripts/mesh_deploy.sh

+
+
+install_mesheryctl(){
+  curl -L https://github.com/meshery/meshery/releases/download/v0.5.67/mesheryctl_0.5.67_Linux_x86_64.zip -o mesheryctl.zip


Don't hardcode the version. Use the same command from the official docs: https://meshery.io. Any reason to deviate?

leecalcote · 2021-11-18T14:21:59Z

.github/workflows/scripts/mesh_deploy.sh

+install_mesheryctl(){
+  curl -L https://github.com/meshery/meshery/releases/download/v0.5.67/mesheryctl_0.5.67_Linux_x86_64.zip -o mesheryctl.zip
+  unzip -n mesheryctl.zip 
+  mv mesheryctl /usr/local/bin/mesheryctl


If you use the approved installation procedure, this is already considered for.

// @hexxdump

pottekkat · 2021-11-18T16:22:10Z

@s1ntaxe770r Could you also add a check in the SMP action to see if Meshery is already installed? Skip install if the environment already has Meshery.

We should also onboard an application on the mesh once it is installed. We could leverage the mesheryctl-service-mesh-patterns-action for this I guess or we could use mesheryctl in the bash script directly as well.

// @sayantan1413 @Utkarsh-pro

Once we have that, we can switch the scripts used in the scheduled benchmarks workflow.

s1ntaxe770r · 2021-11-19T23:10:32Z

@navendu-pottekkat is the action functional now? i haven't been following progress on that.
🤔 about checking if meshery is installed, I thought we were leaving that to the user ? I could be wrong on this

Signed-off-by: Jubril Oyetunji <[email protected]>

leecalcote · 2021-11-19T23:29:59Z

@s1ntaxe770r tests run daily - https://github.com/layer5io/meshery-smp-action/actions

s1ntaxe770r · 2021-11-20T06:34:50Z

I'll address the failing osm deployment in a separate PR

pottekkat · 2021-11-25T12:03:11Z

@s1ntaxe770r The action is functional now. We should ideally check if Meshery is already deployed in the action as I mentioned above. And we should also include deploying the service mesh and an application on the service mesh in this script.

This script takes in arguments, which is good so we can just plug this script in the workflow to deploy a mesh and an application on top of the mesh.

@Revolyssup Can point you to a pattern file that does this. We can start with one mesh and then make progress.

Revolyssup · 2021-11-25T12:05:09Z

@s1ntaxe770r The action is functional now. We should ideally check if Meshery is already deployed in the action as I mentioned above. And we should also include deploying the service mesh and an application on the service mesh in this script.

This script takes in arguments, which is good so we can just plug this script in the workflow to deploy a mesh and an application on top of the mesh.

@Revolyssup Can point you to a pattern file that does this. We can start with one mesh and then make progress.

To get a little context. a patternfile that does "what"? Installs a service mesh?

pottekkat · 2021-11-25T12:13:30Z

@Revolyssup We will use mesheryctl mesh deploy to deploy the service mesh. We need a pattern file that say, onboards BookInfo onto Istio. We want to use mesheryctl for deploying a mesh and onboarding an application, so a pattern file that can onboard applications is what is needed here.

stale · 2022-01-09T21:46:37Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote · 2022-01-09T21:54:44Z

Gents, this has gone stale. What are the next steps here?

s1ntaxe770r · 2022-01-11T13:25:47Z

@leecalcote i think we need to merge this into one review, i accidentally pushed a fix for #25 and #26 over here
#26

leecalcote · 2022-01-11T13:27:09Z

So close this PR?

leecalcote · 2022-01-11T13:27:48Z

This has become stale again, @s1ntaxe770r @navendu-pottekkat.

Should we toss in the towel?

s1ntaxe770r · 2022-01-11T13:31:17Z

Nope, a fix is available in #26

pottekkat · 2022-02-05T06:37:25Z

We can close this and consolidate it to #26

// @s1ntaxe770r

stale · 2022-03-22T10:30:44Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

leecalcote · 2022-03-22T13:21:42Z

@gyohuangxin will you review and decide which direction to go from here?

l5io · 2022-05-20T15:06:27Z

PR abandoned.

add mesh deploy script

226f31e

Signed-off-by: Jubril Oyetunji <[email protected]>

s1ntaxe770r changed the title ~~Use mesheryctl to deploy service meshes~~ Use mesheryctl to deploy service meshes Nov 18, 2021

s1ntaxe770r requested review from DelusionalOptimist, leecalcote and pottekkat November 18, 2021 06:51

Aisuko reviewed Nov 18, 2021

View reviewed changes

s1ntaxe770r added 3 commits November 18, 2021 09:54

fix typo

418e5de

Signed-off-by: Jubril Oyetunji <[email protected]>

fix typo

034c156

Signed-off-by: Jubril Oyetunji <[email protected]>

fix typo

00c910c

Signed-off-by: Jubril Oyetunji <[email protected]>

leecalcote requested a review from Revolyssup November 18, 2021 12:15

leecalcote requested changes Nov 18, 2021

View reviewed changes

use approved installation method

adbd3db

Signed-off-by: Jubril Oyetunji <[email protected]>

s1ntaxe770r force-pushed the feature/s1ntaxe770r/20 branch from 7fb82c3 to adbd3db Compare November 20, 2021 06:36

s1ntaxe770r mentioned this pull request Jan 2, 2022

Use mesheryctl not bash #20

Closed

stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jan 9, 2022

stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jan 9, 2022

stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 22, 2022

stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Mar 22, 2022

gyohuangxin mentioned this pull request Mar 23, 2022

fix failing workflow run #26

Closed

1 task

l5io closed this May 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `mesheryctl` to deploy service meshes #25

Use `mesheryctl` to deploy service meshes #25

s1ntaxe770r commented Nov 18, 2021

Aisuko left a comment

Aisuko Nov 18, 2021

Aisuko Nov 18, 2021

Aisuko Nov 18, 2021

Aisuko Nov 18, 2021

Aisuko Nov 18, 2021

s1ntaxe770r Nov 18, 2021

Aisuko Nov 18, 2021

leecalcote Nov 18, 2021

leecalcote Nov 18, 2021

leecalcote Nov 18, 2021

pottekkat commented Nov 18, 2021

s1ntaxe770r commented Nov 19, 2021

leecalcote commented Nov 19, 2021

s1ntaxe770r commented Nov 20, 2021

pottekkat commented Nov 25, 2021

Revolyssup commented Nov 25, 2021

pottekkat commented Nov 25, 2021

stale bot commented Jan 9, 2022

leecalcote commented Jan 9, 2022

s1ntaxe770r commented Jan 11, 2022

leecalcote commented Jan 11, 2022

leecalcote commented Jan 11, 2022

s1ntaxe770r commented Jan 11, 2022

pottekkat commented Feb 5, 2022 •

edited

Loading

stale bot commented Mar 22, 2022

leecalcote commented Mar 22, 2022

l5io commented May 20, 2022

		@@ -0,0 +1,27 @@
		MESH=$1

		echo "checking if mesheryctl is installed"



		install_mesheryctl(){
		curl -L https://github.com/meshery/meshery/releases/download/v0.5.67/mesheryctl_0.5.67_Linux_x86_64.zip -o mesheryctl.zip

Use mesheryctl to deploy service meshes #25

Use mesheryctl to deploy service meshes #25

Conversation

s1ntaxe770r commented Nov 18, 2021

Aisuko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pottekkat commented Nov 18, 2021

s1ntaxe770r commented Nov 19, 2021

leecalcote commented Nov 19, 2021

s1ntaxe770r commented Nov 20, 2021

pottekkat commented Nov 25, 2021

Revolyssup commented Nov 25, 2021

pottekkat commented Nov 25, 2021

stale bot commented Jan 9, 2022

leecalcote commented Jan 9, 2022

s1ntaxe770r commented Jan 11, 2022

leecalcote commented Jan 11, 2022

leecalcote commented Jan 11, 2022

s1ntaxe770r commented Jan 11, 2022

pottekkat commented Feb 5, 2022 • edited Loading

stale bot commented Mar 22, 2022

leecalcote commented Mar 22, 2022

l5io commented May 20, 2022

Use `mesheryctl` to deploy service meshes #25

Use `mesheryctl` to deploy service meshes #25

pottekkat commented Feb 5, 2022 •

edited

Loading