fix failing workflow run #26
Conversation
Signed-off-by: Jubril Oyetunji <[email protected]>
Signed-off-by: Jubril Oyetunji <[email protected]>
Signed-off-by: Jubril Oyetunji <[email protected]>
Signed-off-by: Jubril Oyetunji <[email protected]>
Signed-off-by: Jubril Oyetunji <[email protected]>
Signed-off-by: Jubril Oyetunji <[email protected]>
|
|
||
| echo "Checking if mesheryctl is installed" | ||
|
|
||
| if mesheryctl |
There was a problem hiding this comment.
Is this command can work well? If I remember right, we need to check the file to use -f parameter in shell.
if [ ! -f "path of mesheryctl" ]; then
echo "Run"
else
echo "Not be found."
fi
There was a problem hiding this comment.
🤔 I tried this method but mesheryctl is not found even though I have it installed. The path I supplied is "/usr/local/bin/mesheryctl", I'm assuming that's the default location mesheryctl would be installed in ?
There was a problem hiding this comment.
Agree with you here, we can check the default path of mesheryctl. And I show you an example:
The command can wrok well on check file.
There was a problem hiding this comment.
👍🏽 thanks for tip @Aisuko that worked
Signed-off-by: Jubril Oyetunji <[email protected]>
oops , that was meant to be a fix for #20 |
|
|
||
|
|
||
| if [ -f "${MESHERYCTL}" ]; then | ||
| echo "Found mesheryctl, deploy $MESH" |
| echo "Found mesheryctl, deploy $MESH" | ||
| mesheryctl mesh deploy $MESH | ||
| else | ||
| printf "Mesheryctl not found. \nInstalling...\n" |
There was a problem hiding this comment.
@Aisuko I'm afraid i don't understand what you mean here
There was a problem hiding this comment.
Hi @s1ntaxe770r, sorry for replying late.. I mean be careful the shell format. Some like the the indentation.
|
@s1ntaxe770r still engaged here? |
|
Yes |
Signed-off-by: Jubril Oyetunji <[email protected]>
|
@s1ntaxe770r We should also switch the scripts used in the workflows with this new script, test and make sure it is working as intended. Any issues in mesheryctl that prevents this should be fixed. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
@gyohuangxin will you review and decide which direction to go from here? |
stale
bot
removed
the
issue/stale
|
@s1ntaxe770r I'm confused about the current status, there are same code changes |
|
PR abandoned. |
Description
the last workflow run for osm failed. this was caused by a case mismatch in the name of the osm binary
This PR fixes #
https://github.com/layer5io/meshery-smp-action/runs/4264742948?check_suite_focus=true
Notes for Reviewers
Signed commits