Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing workflow run #26

Closed
wants to merge 8 commits into from
Closed

fix failing workflow run #26

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
226f31e
add mesh deploy script
s1ntaxe770r Nov 18, 2021
418e5de
fix typo
s1ntaxe770r Nov 18, 2021
034c156
fix typo
s1ntaxe770r Nov 18, 2021
00c910c
fix typo
s1ntaxe770r Nov 18, 2021
adbd3db
use approved installation method
s1ntaxe770r Nov 19, 2021
5d7195b
use lowercase for system name
s1ntaxe770r Nov 20, 2021
506b8b2
fix bug with default path
s1ntaxe770r Dec 9, 2021
066eb61
fix format issues
s1ntaxe770r Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/scripts/mesh_deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
MESH=$1
MESHERYCTL="/usr/local/bin/mesheryctl"
echo "Checking if mesheryctl is installed"


if [ -f "${MESHERYCTL}" ]; then
echo "Found mesheryctl, deploy $MESH"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the format

mesheryctl mesh deploy $MESH
else
printf "Mesheryctl not found. \nInstalling...\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aisuko I'm afraid i don't understand what you mean here

Copy link
Member

@Aisuko Aisuko Jan 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @s1ntaxe770r, sorry for replying late.. I mean be careful the shell format. Some like the the indentation.

curl -L https://git.io/meshery | DEPLOY_MESHERY=false bash -
echo "Installed mesheryctl successfully!"
mesheryctl mesh deploy $MESH

fi
2 changes: 1 addition & 1 deletion .github/workflows/scripts/osm_deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
export MESH_NAME='Open Service Mesh'
export SERVICE_MESH='OPEN_SERVICE_MESH'

system=$(uname -s)
system=$(uname -s | tr '[:upper:]' '[:lower:]')
release=v0.11.1
curl -L https://github.com/openservicemesh/osm/releases/download/${release}/osm-${release}-${system}-amd64.tar.gz | tar -vxzf - ./${system}-amd64/osm version
osm install \
Expand Down