-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: Basic route viewer mode for the main program #165
Open
leezer3
wants to merge
1
commit into
master
Choose a base branch
from
RouteViewing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+184
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1e89a3
to
014a7a1
Compare
This now mostly works as-per Route Viewer. TODO:
|
Another PR which has ended up getting out of sync with master.... Have cherry-picked the commit to render the events, and placed that instead behind a new key option (Set to CTRL+SHIFT+E by default) I think the next step is to cherry-pick the initial loading commit & then rehack the overlays. |
Revisited this today, a little more work done. Flaws:
|
b734a52
to
3f5ad6a
Compare
bad6395
to
438f090
Compare
leezer3
added a commit
that referenced
this pull request
Apr 24, 2023
6679023
to
5f23a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of a viewer mode for the main openBVE program, eventually designed to replace Route Viewer.
To Use:
Flaws:
No event markers.Requires Route Viewer overlays porting. (Should be a relatively quick job.....)