Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: HUD Overlay #938

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: HUD Overlay #938

wants to merge 3 commits into from

Conversation

Kenny-Hui
Copy link
Contributor

This PR syncs all newly added elements to all size of HUD (Not only default), improve margins and texture on the Large HUD, and fixes a bug where the background texture would be rendered instead of the overlay texture, which reverts the HUD back to the way it used to look.

Before:
image

After:
image

@leezer3
Copy link
Owner

leezer3 commented Aug 29, 2023

Thanks.

Is there a reason for setting the alpha value of the text to 255 as opposed to 192?
Only thing I'm thinking is that there will be complaints about it having changed.....

@Kenny-Hui
Copy link
Contributor Author

I think having the text being opaque makes the text slightly more legible, although it's just a subtle change and I wouldn't mind reverting for whatever reason.

As for the design, I am thinking to drop the overlay border entirely as it only seems to complicate things in different HUD sizes and looks a bit busy.

I am mainly just bothered by the currently brightened color in the handle and door control, which imo is a bit too bright and clashes with the text color.

@leezer3
Copy link
Owner

leezer3 commented Aug 29, 2023

Don't disagree in principle.
Thinking sideways a bit, if dropping the border, it ought to be possible to do the overlays in pure GL as opposed to using a texture- All they are is a simple quad after all.

@Kenny-Hui
Copy link
Contributor Author

Probably a good idea, though I am thinking more on expanding the HUD feature instead of dropping the entire customizing the HUD thing, it can come handy at times. (So maybe you specify a subject in interface.cfg and it renders in pure GL, although the interface.cfg format is a mess in of itself)

Or maybe I am just overthinking over a HUD feature...

@leezer3
Copy link
Owner

leezer3 commented Aug 29, 2023

Yep, definitely a mess.
Only thing with specifying GL in interface.cfg is that would have to be GL3 only I'd have thought.

Dropping 1.2 probably ought to be done soon, but meh...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants