Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve progress bar update API #681

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

mdekstrand
Copy link
Member

No description provided.

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Mar 27, 2025
@mdekstrand mdekstrand added this to the 2025.3 milestone Mar 27, 2025
@mdekstrand mdekstrand changed the title Support directly setting completed= Improve progress bar update API Mar 27, 2025
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.99%. Comparing base (4dbdbdd) to head (0ffd8b8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/lenskit/logging/progress/_notebook.py 0.00% 6 Missing ⚠️
src/lenskit/logging/progress/_rich.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #681      +/-   ##
==========================================
- Coverage   90.02%   89.99%   -0.03%     
==========================================
  Files         134      134              
  Lines        9299     9295       -4     
==========================================
- Hits         8371     8365       -6     
- Misses        928      930       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdekstrand mdekstrand merged commit 91fa9f8 into lenskit:main Mar 27, 2025
31 of 33 checks passed
@mdekstrand mdekstrand deleted the feature/direct-progress-update branch March 27, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant