Improve progress bar update API

src/lenskit/cli/__init__.py

@@ -12,7 +12,6 @@
 
 from lenskit import __version__
 from lenskit.logging import LoggingConfig, console, get_logger
-from lenskit.logging.processors import error_was_logged
 
 __all__ = ["lenskit", "main", "version"]
 _log = get_logger(__name__)

src/lenskit/logging/config.py

@@ -21,7 +21,7 @@
 import structlog
 
 from ._console import ConsoleHandler, console, setup_console
-from .processors import format_timestamp, log_warning, record_logged_error, remove_internal
+from .processors import format_timestamp, log_warning, remove_internal
 from .progress import set_progress_impl
 from .tracing import lenskit_filtering_logger
 
@@ -187,7 +187,6 @@ def apply(self):
         )
         formatter = structlog.stdlib.ProcessorFormatter(
             processors=[
-                record_logged_error,
                 remove_internal,
                 format_timestamp,
                 proc_fmt,

src/lenskit/logging/processors.py

@@ -19,27 +19,6 @@
 LOGGED_ERRORS = deque([], 5)
 
 
-def error_was_logged(exc: Exception) -> bool:
-    """
-    Query whether an exception was logged.
-    """
-    return exc in LOGGED_ERRORS
-
-
-def record_logged_error(logger: Any, method: str, event_dict: EventDict):
-    """
-    Keep a record of recently-logged errors to avoid duplicate rendering in some
-    cases.
-    """
-
-    exc = event_dict.get("exc_info", None)
-
-    if isinstance(exc, Exception):
-        LOGGED_ERRORS.append(exc)
-
-    return event_dict
-
-
 def remove_internal(logger: Any, method: str, event_dict: EventDict) -> EventDict:
     """
     Filter out “internal” attrs (beginning with ``_``) for console logging.

src/lenskit/logging/progress/_base.py

@@ -17,9 +17,23 @@ class Progress:
     def __init__(self, *args: Any, **kwargs: Any):
         pass
 
-    def update(self, advance: int = 1, **kwargs: float | int | str):
+    def update(
+        self,
+        advance: int = 1,
+        completed: int | None = None,
+        total: int | None = None,
+        **kwargs: float | int | str,
+    ):
         """
         Update the progress bar.
+
+        Args:
+            advance:
+                The amount to advance by.
+            completed:
+                The number completed; this overrides ``advance``.
+            total:
+                A new total, to update the progress bar total.
         """
         pass
 

src/lenskit/logging/progress/_notebook.py

@@ -67,11 +67,22 @@
                 [f"{name}: {field_format(name, fs)}" for (name, fs) in fields.items()]
             )
 
-    def update(self, advance: int = 1, **kwargs: float | int | str):
+    def update(
+        self,
+        advance: int = 1,
+        completed: int | None = None,
+        total: int | None = None,
+        **kwargs: float | int | str,
+    ):
         """
         Update the progress bar.
         """
-        self.current += advance
+        if total is not None:
+            self.total = total
+        if completed is not None:
+            self.current = completed
+        else:
+            self.current += advance
         now = perf_counter()
         if now - self._last_update >= 0.1 or (self.total and self.current >= self.total):
             self.widget.value = self.current

src/lenskit/logging/progress/_rich.py

@@ -67,12 +67,24 @@
                 ]
             )
 
-    def update(self, advance: int = 1, **kwargs: float | int | str):
+    def update(
+        self,
+        advance: int = 1,
+        completed: int | None = None,
+        total: int | None = None,
+        **kwargs: float | int | str,
+    ):
         extra = ""
         if self._field_format:
             extra = self._field_format.format(**kwargs)
         if _progress is not None:
-            _progress.update(self._task, advance=advance, extra=extra)  # type: ignore
+            _progress.update(
+                self._task,  # type: ignore
+                advance=advance if completed is None else None,
+                completed=completed,
+                total=total,
+                extra=extra,
+            )
 
     def finish(self):
         _remove_bar(self)